Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add object properties for composed units #1816

Merged
merged 11 commits into from
Feb 29, 2024

Conversation

l-emele
Copy link
Contributor

@l-emele l-emele commented Feb 23, 2024

Summary of the discussion

Type of change (CHANGELOG.md)

Add

  • has unit numerator
    • has linear numerator
    • has squared numerator
    • has cubed numerator
  • has unit denominator
    • has linear denominator
    • has squared denominator
    • has cubed denominator

Workflow checklist

Automation

Closes #1815

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@github-actions github-actions bot added the oeo-shared changes the oeo-shared module label Feb 23, 2024
@l-emele l-emele marked this pull request as ready for review February 23, 2024 11:09
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@stap-m stap-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if the example of usage should be added to the subrelations as well.

src/ontology/edits/oeo-shared.omn Outdated Show resolved Hide resolved
@l-emele
Copy link
Contributor Author

l-emele commented Feb 23, 2024

I am wondering if the example of usage should be added to the subrelations as well.

I asked that myself, too. I added the elucidation to the subproperties, too. It is redundant, but it does not hurt.

@l-emele l-emele added this to the oeo-release-2.2.0 milestone Feb 26, 2024
@l-emele l-emele merged commit 8d48235 into dev Feb 29, 2024
4 checks passed
@l-emele l-emele deleted the feature-1815-relations-for-composed-units branch February 29, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-shared changes the oeo-shared module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Composed units need relations
2 participants